Add segmentation data publisher to camera plugin #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segmentation topic will appear for Camera nodes that have segmentation available. Data will only be published if subscribers are connected.
Fixed issue where segmentation did not work unless recognition was also subscribed
|
@dscroft Thank you. I synced with the main branch and allowed CI. It looks good. Could you please add a changelog. It would also be good to add a simple test. |
added 2 commits
August 29, 2024 15:16
World has been slightly modified to enable segmentation on the camera. Test checks for width and height of recieved image, black pixels in the image (no object), red pixels in the image (object segmentation highlight).
|
Test added |
|
@dscroft Thank you for the test. It seems there is a bug, can you take a look: |
Segmentation data is not available in first frame so set comparison was failing.
|
Found the issue, pushed fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segmentation topic will appear for Camera nodes that have segmentation available. Data will only be published if subscribers are connected.
Description
Camera plugin does not have segmentation data available.
Related Issues
N/A
Affected Packages
List of affected packages:
Tasks
NA
Additional context
NA